-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win 2019 CIS v1.3.0 release #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
MrSteve81
added
enhancement
New feature or request
documentation
Improvements or additions to documentation
labels
Mar 20, 2023
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
uk-bolly
reviewed
Mar 21, 2023
uk-bolly
reviewed
Mar 21, 2023
uk-bolly
reviewed
Mar 21, 2023
uk-bolly
reviewed
Mar 21, 2023
uk-bolly
reviewed
Mar 21, 2023
uk-bolly
reviewed
Mar 21, 2023
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Looking good so far, thanks Steve!! :) |
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
uk-bolly
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@IPvFletch Merged into Devel. Feel free to head over to discord if you have questions im there all the time. |
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Williams stephenw@mindpointgroup.com
Overall Review of Changes:
Complete Update to Win 2019 1.3.0 Release
Added naming convention to align with all roles to all variables.
Issue Fixes:
#65
#64
#31
Enhancements:
Additional Variables added to the default main for ranges that user an specify
Added Warning system for inaccurate or bad variables entered.
How has this been tested?:
Locally