Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

April pipeline fixes, Workflow files, Added Cloud Support For Tasks 1.2.1 - 3 #71

Merged
merged 15 commits into from
May 11, 2023

Conversation

MrSteve81
Copy link
Contributor

Overall Review of Changes

April pipeline fixes, Workflow files, Added Cloud Support For Tasks 1.2.1 - 3

Issue Fixes

N/A

Enhancements

N/A

How has this been tested?

Locally and using terraform pipelines in azure.

Please give an overview of how these changes were tested. If they were not please use N/A

Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be ignored ideally so each add needs to be force updated. minimise potentail files in location that shouldn't be there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the random plugin is not required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added CIS to it for pipeline identifying where it originated for azure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add other cloud platforms? so we ensure we skip all cloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Additional

Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Signed-off-by: Stephen Williams <stephenw@mindpointgroup.com>
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@MrSteve81 MrSteve81 merged commit 994f7ce into devel May 11, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants