Add become_user to artemis commands
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
added
the
bugfixes
guidograzioli
force-pushed
the
13_amq_instance_owned_by_root
branch
from
f11a334
to
f253216
Compare
guidograzioli
force-pushed
the
13_amq_instance_owned_by_root
branch
from
f253216
to
ecc5567
Compare
rpelisse
reviewed
Aug 30, 2022
| ansible.builtin.include_role: | ||
| name: amq_broker | ||
| when: local_archive_path.stat.exists |
There was a problem hiding this comment.
@guidograzioli yet another opportunity for the exists jinja filter!
rpelisse
reviewed
Aug 30, 2022
| - name: Set ownership on nfs mounted parent | ||
| file: | ||
| path: /opt/amq/amq-broker/ |
There was a problem hiding this comment.
@guidograzioli is there not a amq_home variable to be used here? This hard coded path will be complicated the minute user use a different folder for AMQ.
There was a problem hiding this comment.
it is in a test preparation, before the role executes (with the defaults)
rpelisse
approved these changes
Aug 30, 2022
guidograzioli
changed the title
become_user to artemis commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13