Variable to config controller download/offline directory #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
added
the
minor_changes
rpelisse
reviewed
Aug 30, 2022
| @@ -56,7 +56,7 @@ | |||
| ## download to controller | |||
| - name: Check local download archive path | |||
| ansible.builtin.stat: | |||
| path: "{{ lookup('env', 'PWD') }}" | |||
| path: "{{ activemq_local_archive_repository }}" | |||
There was a problem hiding this comment.
@guidograzioli yet another opportunity to remove stat: and use the jinja filter!
rpelisse
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New variable
activemq_local_archive_repositoryconfigures a directory accessible from controller to use for downloading/installing provided install archives. Default isansible-playbookcommand$PWD(as previously set) so no change is necessary if the config is not used.activemq_offline_installFalseactivemq_local_archive_repository{{ lookup('env', 'PWD') }}