Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration parameters for journal #43

Merged

Conversation

guidograzioli
Copy link
Member

@guidograzioli guidograzioli commented Jan 16, 2023

Add role parameters to configure the journal:

  • Journal configuration
Variable Description Default
activemq_persistence_enabled Whether to use the file based journal for persistence" True
activemq_persist_id_cache Whether to persist cache IDs to the journal' True
activemq_id_cache_size The duplicate detection circular cache size' 20000
activemq_journal_type Journal type, valid values are [ ASYNCIO: libaio, MAPPED: mmap files, NIO: Plain Java Files ] ASYNCIO
activemq_paging_directory The directory to store paged messages in' data/paging
activemq_bindings_directory The folder in use for the bindings folder' data/bindings
activemq_journal_directory The directory to store the journal files in' data/journal
activemq_large_messages_directory The directory to store large messages' data/largemessages
activemq_journal_datasync Whether to use msync/fsync on journal operations' True
activemq_journal_min_files How many journal files to pre-create' 2
activemq_journal_pool_files The upper threshold of the journal file pool, -1 means no Limit' -1
activemq_journal_device_block_size The block size by the device' 4096
activemq_journal_file_size The size (in bytes) of each journal file' 10M
activemq_journal_buffer_timeout The Flush timeout for the journal buffer' 500000 if 'ASYNCIO' else 3333333
activemq_journal_max_io The maximum number of write requests that can be in the ASYNCIO queue at any one time' 4096 if 'ASYNCIO' else 1
activemq_db_jdbc_url The full JDBC connection URL for your database server' jdbc:derby:target/derby/database-store;create=true
activemq_db_bindings_table The name of the table in which bindings data will be persisted' BINDINGS_TABLE
activemq_db_message_table The name of the table in which bindings data will be persisted' MESSAGE_TABLE
activemq_db_large_message_table The name of the table in which messages and related data will be persisted' LARGE_MESSAGES_TABLE
activemq_db_jdbc_driver_class The fully qualified class name of the desired database Driver' org.apache.derby.jdbc.EmbeddedDriver

Also, refactor tasks fixing #10

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Jan 16, 2023
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

block:
- name: Ensure lib is available to instance
ansible.builtin.copy:
src: "{{ activemq.home }}/lib/artemis-prometheus-metrics-plugin-1.1.0.redhat-00002.jar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the filename be parameterized?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the plan for handling that filename is to add a find task before the copy; will address in a different PR, this change only moves that part of code from systemd.yml to configure_broker.yml as per #10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants