Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to connectors config (add parameter for NIC name selection) #84

Merged

Conversation

guidograzioli
Copy link
Member

@guidograzioli guidograzioli commented Jul 17, 2023

This change contains a rework of how connectors configuration is declared/generated, in the case of static_cluster discovery. After the change, settings declared in activemq_connectors are merged with similar settings generated by the collection inferred from play hosts and global variables (formerly, declared settings would override generated settings).

This means that now a deployment of two hosts in static_cluster config, can only declare:

- name: instance2
  parameters:
    sslEnabled: true
    keyStorePath: "{{ activemq_tls_keystore_dest }}"
    keyStorePassword: "{{ activemq_tls_keystore_password }}"

winstead of the wholly defined:

- name: instance2
  address: instance2
  port: "{{ activemq_port }}"
  parameters:
    tcpSendBufferSize: 1048576
    tcpReceiveBufferSize: 1048576
    protocols: CORE
    useEpoll: true
    sslEnabled: true
    keyStorePath: "{{ activemq_tls_keystore_dest }}"
    keyStorePassword: "{{ activemq_tls_keystore_password }}"

New role parameter:

Variable Description Default
activemq_cluster_iface The NIC name to be used for cluster IPv4 addresses (ie. 'eth0') default_ipv4

will be used to select the specified network interface name when gathering target host IP addresses during cluster formation. By default, default_ipv4, retains the behaviour of picking the NIC that ansible considers default.

Fix #62

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Jul 17, 2023
@guidograzioli guidograzioli changed the title Add paramenter for NIC name selection Update to connectors config (add parameter for NIC name selection) Jul 17, 2023
@guidograzioli guidograzioli merged commit c509464 into ansible-middleware:main Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
1 participant