Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Add zk inventory group var into broker role #46

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

rmarting
Copy link
Collaborator

This PR fixes an issue coming from the #44. The amq_streams_zookeeper_inventory_group variable must be part also the amq_streams_broker role just because the server.properties.j2 template uses it to set up the connection to the zookeeper cluster.

The issue was:

TASK [amq_streams_common : Ensure amq_streams_broker configuration is deployed.] **********************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'amq_streams_zookeeper_inventory_group' is undefined
fatal: [f38mw01]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'amq_streams_zookeeper_inventory_group' is undefined"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'amq_streams_zookeeper_inventory_group' is undefined

@rpelisse Can you review it? Maybe there is another way to declare these variables to identify the group vars.

@rpelisse rpelisse merged commit 51f60b6 into ansible-middleware:main Jul 17, 2023
1 check passed
@rmarting rmarting deleted the fix-inventory-vars branch July 18, 2023 08:07
@rpelisse rpelisse added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants