Set up KAFKA environment variables for the service execution #54
Conversation
|
@rmarting Can you review this PR (and maybe test it a bit)? Thanks! |
| @@ -27,4 +27,6 @@ | |||
| server_group: "{{ amq_streams_connect_group | default(omit) }}" | |||
| server_java_opts: "{{ amq_streams_connect_java_opts | default('') }}" | |||
| server_java_heap_opts: "{{ amq_streams_connect_java_heap_opts | default('') }}" | |||
| server_java_performance_opts: "{{ amq_streams_connect_java_performance_opts | default('') }}" | |||
| server_java_gc_log_opts: "{{ amq_streams_connect_java_java_gc_log_opts | default('') }}" | |||
There was a problem hiding this comment.
I am missing the definiton for the jmx, something similar to:
server_java_jmx_opts: "{{ amq_streams_connect_java_jmx_opts | default('') }}"
Is there a reasson for that? That variable is declared for Broker and Zookeeper, but not for the Kafka Connect.
There was a problem hiding this comment.
@rpelisse Tested and verified everything successfully. Only a minor details for the Kafka Connect service. Added a comment about that. ✔️
For the rest of the implementation. LGTM.
There was a problem hiding this comment.
Another comment, I found that the server_log4j_opts variable is not declared to be used for the service task. I mean, I don't see how to identify a value for that variable.
Am I missing something?
There was a problem hiding this comment.
@rpelisse I think you missed this comment! As I can't find the way to declare that variable for each component. Am I missing sth? Thanks
rpelisse
added
the
minor_changes
No description provided.