Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage topics in a Kafka authenticated broker #60

Merged
merged 9 commits into from
Jul 25, 2023

Conversation

rmarting
Copy link
Collaborator

@rmarting rmarting commented Jul 24, 2023

This PR extends the kafka topics tasks of the amq_streams_broker role when the Kafka broker is authenticated.

The PR also extends the documentation describing how to create, describe or delete topics using the role.

This PR is fixing the issue #10, but only the topics scenario (50% of that issue 😄 )

@rpelisse
Copy link
Collaborator

@rmarting the amq_streams_broker_admin_mechanism is not defined, that's why this is failing. I've added the documented value to the default value:
amq_streams_broker_admin_mechanism: PLAIN

However, it stills fails (locally):

[2023-07-25 07:39:30,697] WARN These configurations '[//]' were supplied but are not used yet. (org.apache.kafka.clients.admin.AdminClientConfig)
[2023-07-25 07:39:30,895] ERROR [AdminClient clientId=adminclient-1] Connection to node -1 (localhost/127.0.0.1:9092) failed authentication due to: Unexpected handshake request with client mechanism PLAIN

@rmarting
Copy link
Collaborator Author

@rpelisse Fixed, and CI is 💚

Can you review it? Thanks

@rpelisse rpelisse merged commit 853dd79 into ansible-middleware:main Jul 25, 2023
1 check passed
@rmarting rmarting deleted the auth-topic-mngt branch July 25, 2023 10:47
@rpelisse rpelisse added the major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants