Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom zookeeper_id for each host based in inventory #99

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

gbaufake
Copy link
Contributor

@gbaufake gbaufake commented Oct 9, 2023

@rmarting
Copy link
Collaborator

@gbaufake Just a comment to improve this PR (before a better revision of @rpelisse):

  • The variables for a role should start with the name of the role (e.g: amq_streams_zookeeper_XXX)
  • It is important to document the variable, default values, and scope to help its use (adding an example is much appreciated)

Thanks your contribution!

Copy link
Collaborator

@rmarting rmarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you review our comments? Thanks

Copy link
Collaborator

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update your PR following Roman's feedback? :)

@rpelisse rpelisse added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Oct 12, 2023
@rpelisse rpelisse merged commit 6a807c5 into ansible-middleware:main Oct 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom zookeeper id for each host based in inventory
3 participants