Make playbook compatible with multiple installations on same host #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
added
the
minor_changes
rpelisse
reviewed
Apr 6, 2022
| bind_addr: "{{ jdg_bind_address }}" | ||
| port: "{{ jdg_port }}" | ||
| port: "{{ jdg_port + jdg_port_offset }}" |
There was a problem hiding this comment.
@guidograzioli I honestly don't know if handling the logic of port_offset here is either brilliant or going to come back to bite us in the butt! (but let's go with it for now)
There was a problem hiding this comment.
That was only the beginning for this change
|
LGTM! |
guidograzioli
changed the title
guidograzioli
added
major_changes
|
@guidograzioli lgtm! Please merge and rebase at your earliest convenience :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9
Limitations:
roles: [ <role> ]instead ofinclude_rolebecause of https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse_roles.html#passing-different-parametersSummary of changes:
jdg_nodenameparameter for specifying instance name in clusterjdg_port_offsetparam to specify alternate portscache_configparam specification in arguments_spec