Add sqlserver to infinispan jdbc configurations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome; sorry to say so, but please split in two PRs: database and systemd (keeping the become change together with either of the two). We use the PR link and description to generate the changelog, that's mostly the reason |
|
We are hitting the same linter updates as for keycloak; can you please rebase on main? |
|
Rebased. |
guidograzioli
added
the
minor_changes
guidograzioli
requested changes
Jun 19, 2023
…ailure
<!-- <FD_SOCK stack.combine="REMOVE"/> having this line using JDG v8.4.1 leads to `DefaultCacheManager start failed, stopping any running components org.infinispan.commons.CacheConfigurationException` due to `org.infinispan.commons.CacheConfigurationException: ISPN000544: The protocol 'FD_SOCK' does not exist in the base stack for operation 'REMOVE'`-->
guidograzioli
approved these changes
Jun 20, 2023
|
Thank you for the contribution! This is going in now |
guidograzioli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
become: yeshandling (tested with JDG only)infinispan_jdbc_engine['mariadb','postgres','sqlserver'])mariadb