Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add offline_install parameters, move file checks up when offline #248

Merged
merged 8 commits into from
Oct 10, 2023
Merged

add offline_install parameters, move file checks up when offline #248

merged 8 commits into from
Oct 10, 2023

Conversation

guidograzioli
Copy link
Member

No description provided.

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Oct 9, 2023
@guidograzioli guidograzioli force-pushed the offline_installs branch 2 times, most recently from 99313a2 to 7b3c047 Compare October 10, 2023 12:15
rpelisse
rpelisse requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing, about a varname... We may need to add it to the arg_specs for documentation purpose.

roles/jws/tasks/uninstall.yml Outdated Show resolved Hide resolved
rpelisse
rpelisse approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidograzioli guidograzioli merged commit 0ba41bf into ansible-middleware:main Oct 10, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpelisse rpelisse rpelisse approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guidograzioli @rpelisse