Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make playbook become unnecessary #274

Merged
merged 13 commits into from
Mar 20, 2024
Merged

Make playbook become unnecessary #274

merged 13 commits into from
Mar 20, 2024

Conversation

guidograzioli
Copy link
Member

@guidograzioli guidograzioli commented Mar 13, 2024 •
edited

This change-set updates both jws and jws_validation roles to be executed without become: True at the play level, and all tests accordingly.

@guidograzioli guidograzioli added the major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to label Mar 14, 2024
@guidograzioli guidograzioli changed the title Ssh as jenkins Make playbook become unnecessary Mar 14, 2024
@guidograzioli guidograzioli force-pushed the ssh_as_jenkins branch 2 times, most recently from 4b7ebf4 to 3261efb Compare March 14, 2024 16:06
@guidograzioli guidograzioli added minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix and removed major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to labels Mar 14, 2024
@guidograzioli guidograzioli force-pushed the ssh_as_jenkins branch 2 times, most recently from e6c45f7 to 08f7be9 Compare March 14, 2024 16:53
rpelisse
rpelisse approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidograzioli guidograzioli merged commit 86e46a8 into main Mar 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpelisse rpelisse rpelisse approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guidograzioli @rpelisse