keycloak_quarkus: enable config of key store and trust store #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Footur
force-pushed
the
keystore
branch
2 times, most recently
from
b135c48
to
e842462
Compare
|
Looks good to me, thanks for the PR! I'll mark it "breaking change" because of the parameter renaming, and will need to edit the PR title and text with details after merging, for the changelog. The next release will be a major version bump, so no problem about it. |
guidograzioli
added
the
breaking_changes
|
Cool, thanks for feedback. 👍 |
guidograzioli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: the parameter
keycloak_quarkus_https_enabledof role keycloak_quarkus has been renamed tokeycloak_quarkus_https_key_file_enabled.New parameters:
keycloak_quarkus_key_store_file{{ keycloak.home }}/conf/key_store.p12keycloak_quarkus_key_store_password""keycloak_quarkus_https_trust_store_enabledFalsekeycloak_quarkus_trust_store_file{{ keycloak.home }}/conf/trust_store.p12keycloak_quarkus_trust_store_password""