Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new parameter for port offset configuration #124

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Add new parameter for port offset configuration #124

merged 8 commits into from
Nov 6, 2023

Conversation

jacobdotcosta
Copy link
Contributor

@jacobdotcosta jacobdotcosta commented Oct 30, 2023 •
edited by guidograzioli

New parameter that allows to configure service port offset:

Variable Description Default
keycloak_jboss_port_offset Port offset for the JBoss socket binding 0

Closes #57

@jacobdotcosta jacobdotcosta mentioned this pull request Oct 30, 2023
Closed
@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Nov 3, 2023
@guidograzioli
Copy link
Member

Thanks for the PR! Can you please rebase?

guidograzioli and others added 7 commits November 6, 2023 15:01
@guidograzioli @jacobdotcosta
linter
12147b4
@jacobdotcosta
feat: add a destination variable for the log link
a538828 
docs: argument specs for the keycloak_quarkus_log_target

docs: added parameter to the roles README

fix: role variable is keycloak_log_target and not keycloak_quarkus_log_target
@Footur @jacobdotcosta
Update Keycloak to version 22.0.5
62e5380
@guidograzioli @jacobdotcosta
molecule test for keycloakx with proxy
03175e2
@guidograzioli @jacobdotcosta
ddisable new test
61730b9
@jacobdotcosta
rebase for changes made in PR 120
5543217
@jacobdotcosta
Merge branch 'main' into issue-57
027ac1a
@guidograzioli
Copy link
Member

Brilliant, thank you very much for the contribution

guidograzioli
guidograzioli approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guidograzioli guidograzioli merged commit 92639e4 into ansible-middleware:main Nov 6, 2023
14 checks passed
@guidograzioli guidograzioli changed the title feat: jboss port offset configuration Add keycloak_jboss_port_offset for port offset configuration Nov 6, 2023
@guidograzioli guidograzioli changed the title Add keycloak_jboss_port_offset for port offset configuration Add new parameter for port offset configuration Nov 6, 2023
@jacobdotcosta jacobdotcosta deleted the issue-57 branch November 13, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing PORT Offset conffiguration
3 participants
@jacobdotcosta @guidograzioli @Footur