Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak_quarkus: renamed infinispan host list configuration #157

Merged

Conversation

hwo-wd
Copy link
Collaborator

@hwo-wd hwo-wd commented Jan 17, 2024

This changeset contains a parameter rename for the keycloak_quarkus role, which reflects a renaming that happened in the upstream project.

The removed parameter is keycloak_quarkus_ispn_url, which is superseeded by:

Variable Description Default
keycloak_quarkus_ispn_hosts semicolon separated hostname:port for connecting to infinispan, eg. host1:11222;host2:11222 localhost:11222

Fix #146
Fix #156

@hwo-wd
Copy link
Collaborator Author

hwo-wd commented Jan 17, 2024

@guidograzioli unsure whether you want to introduce the breaking change keycloak_quarkus_ispn_url -> keycloak_quarkus_ispn_hosts; the renaming would make it clearer though, that we are NOT setting [quarkus.infinispan-client.uri(https://quarkus.io/version/3.2/guides/all-config#quarkus-infinispan-client_quarkus.infinispan-client.-named-infinispan-clients-.uri)

@hwo-wd
Copy link
Collaborator Author

hwo-wd commented Jan 18, 2024

I presume this fixes #146, too.

Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good as it stands (actually, can you bump the minor to 2.1.0 pls?) ; I'll reword the PR title and description because marking the change as breaking.

@guidograzioli guidograzioli added the breaking_changes MUST include changes that break existing playbooks label Jan 18, 2024
@guidograzioli guidograzioli changed the title fix #156: quarkus 3 ispn config renamings keycloak_quarkus: renamed infinispan host list configuration Jan 18, 2024
@guidograzioli guidograzioli merged commit 64fa8bb into ansible-middleware:main Jan 22, 2024
16 checks passed
@hwo-wd hwo-wd deleted the fix/156_infinispan branch April 16, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_changes MUST include changes that break existing playbooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keycloak_quarkus: Infinispan settings quarkus.properties not loaded by default
2 participants