Implement infinispan TCPPING discovery protocol #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwo-wd
changed the title
|
@guidograzioli anything you want to change on this one, or the two other PRs? -- thanks. |
No prob with the changes, I just hadn't time to review yet sorry |
| - name: "Rebuild {{ keycloak.service_name }} config" | ||
| ansible.builtin.shell: | | ||
| {{ keycloak.home }}/bin/kc.sh build | ||
| become: true |
There was a problem hiding this comment.
Because this is imported from the handler, and notified when that change is required, I'd changed_when: True this one. wdyt?
hwo-wd
force-pushed
the
feature/inifinispan_ha
branch
from
1f5f316
to
df81dc5
Compare
guidograzioli
added
minor_changes
guidograzioli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kc.sh buildinvocation in order to minimize startup time; moreover, I had issues with getting TCPPING config to work since keycloak, upon a regular invocation ofkc.sh startcreates it's own internal cache which is kept until a build is re-run; this newly added handler will save us some headaches in futurekc.sh start --optimizedin case--start-devis not executed, thus re-using the aforementioned pre-built configurationFix #158