New keycloak_quarkus_hostname_strict_https parameter
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
requested changes
Apr 18, 2024
guidograzioli
added
the
minor_changes
|
@guidograzioli I modified it to better handle ensuring that the value is a boolean and it should address your concern as well. |
|
Thanks for updating, but the specification for the new parameter is still needed here: |
|
@guidograzioli OK, I think that latest change should cover it. Thanks! |
guidograzioli
changed the title
keycloak_quarkus_hostname_strict_https parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #193
Added a new option
keycloak_quarkus_hostname_strict_httpswith no default value.If the option is set, the Jinja template for
keycloak.conf.j2checks to see if the value is eithertrueorfalseand applies it appropriately