Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize jdbc driver downloads, optional authentication #202

Merged
merged 3 commits into from
May 1, 2024
Merged

Customize jdbc driver downloads, optional authentication #202

merged 3 commits into from
May 1, 2024

Conversation

InfoSec812
Copy link
Contributor

@InfoSec812 InfoSec812 commented Apr 30, 2024 •
edited by guidograzioli

Add three new parameters which allow for overriding the download URL for the JDBC driver and also specifying credentials for downloading those JDBC drivers.

Variable Description Required
keycloak_quarkus_jdbc_download_url Override the default Maven Central download URL for the JDBC driver no
keycloak_quarkus_jdbc_download_user Set a username with which to authenticate when downloading JDBC drivers from an alternative location no
keycloak_quarkus_jdbc_download_pass Set a password with which to authenticate when downloading JDBC drivers from an alternative location (requires keycloak_quarkus_jdbc_download_user) no

Resolves #200

guidograzioli
guidograzioli approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the contribution!

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label May 1, 2024
@guidograzioli guidograzioli changed the title Issue 200: Customize jdbc driver downloads Customize jdbc driver downloads, optional authentication May 1, 2024
@guidograzioli guidograzioli merged commit 41cbcc4 into ansible-middleware:main May 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for downloading JDBC drivers from alternate URLs and allow for using username/password
2 participants
@InfoSec812 @guidograzioli