Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDBC provider: fix clause in argument validation #204

Merged
merged 2 commits into from
May 2, 2024
Merged

JDBC provider: fix clause in argument validation #204

merged 2 commits into from
May 2, 2024

Conversation

InfoSec812
Copy link
Contributor

Resolves #203

@InfoSec812 InfoSec812 changed the title Fix logic in when clause WIP: Fix logic in when clause May 2, 2024
@InfoSec812 InfoSec812 changed the title WIP: Fix logic in when clause Fix logic in when clause May 2, 2024
@InfoSec812
Copy link
Contributor Author

This is working in our local environment as expected with these changes.

@guidograzioli guidograzioli added the bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements label May 2, 2024
@guidograzioli guidograzioli merged commit d16c23f into ansible-middleware:main May 2, 2024
18 checks passed
@guidograzioli guidograzioli changed the title Fix logic in when clause JDBC provider: fix clause in argument validation May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I introduced a bug in the parameter validation which causes the role to fail
2 participants
@InfoSec812 @guidograzioli