Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying of key material for TLS configuration #210

Merged
merged 3 commits into from
May 6, 2024
Merged

Copying of key material for TLS configuration #210

merged 3 commits into from
May 6, 2024

Conversation

Footur
Copy link
Contributor

@Footur Footur commented May 3, 2024

This pull request updates the configuration to use the standard Red Hat Enterprise Linux (RHEL) default path for TLS certificates.

Also, it copies the private key and certificate to the target host.

#208

@Footur
Enable copying of key material
9bc1ae6 
This commit updates the configuration to use the standard Red Hat
Enterprise Linux (RHEL) default path for TLS certificates, which is
/etc/pki/tls.

Also, it copies the private key and certificate to the target host.
guidograzioli
guidograzioli requested changes May 3, 2024
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR; the change looks good, but can i ask to also update the quarkus molecule test to use the functionality? (instead of using the prepare.yml to copy the files)

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label May 3, 2024
@Footur
Copy link
Contributor Author

Footur commented May 5, 2024

@guidograzioli I have updated the Molecule test. Does it meet your expectations?

@Footur
Copy the TLS private key from memory
320a5f0 
This change should avoid storing plain private keys on disk due to
security risks. It also makes it easier to encrypt the data with SOPS.
@guidograzioli guidograzioli merged commit fa39e9b into ansible-middleware:main May 6, 2024
18 checks passed
@guidograzioli guidograzioli changed the title Enable copying of key material Copying of key material for TLS configuration May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Footur @guidograzioli