Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile features enabling/disabling #87

Merged

Conversation

hwo-wd
Copy link
Collaborator

@hwo-wd hwo-wd commented May 30, 2023

As per https://access.redhat.com/documentation/en-us/red_hat_single_sign-on/7.6/html-single/server_installation_and_configuration_guide/index#profiles, a new parameter allows to arbitrarily enable (or disable) profile features from Red Hat Single Sign-on:

Variable Description Default
keycloak_features List of { 'name', 'status' } dicts where name is a feature
and status is enable or disable
[]

Example usage:

      keycloak_features:
        - name: "declarative_user_profile"
          status: 'enabled'
        - name: "admin_fine_grained_authz"
          status: 'disabled'

@guidograzioli
Copy link
Member

Hello, thanks for the contribution. I appreciate the focus of the change, but I'd much prefer for the profile.properties file to be deployed, instead of appending to the command line (which could become very very long this way). Would you mind to amend?

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label May 31, 2023
@hwo-wd
Copy link
Collaborator Author

hwo-wd commented May 31, 2023

There you go,

      keycloak_features:
        - name: "declarative_user_profile"
          status: 'enabled'
        - name: "admin_fine_grained_authz"
          status: 'enabled'

produces:

image

while

      keycloak_features:
        - name: "declarative_user_profile"
          status: 'enabled'
        - name: "admin_fine_grained_authz"
          status: 'disabled'

leads to

image

With the corresponding profile.properties:

[root configuration]# cat profile.properties
feature.declarative_user_profile=enabled
feature.admin_fine_grained_authz=disabled

@guidograzioli
Copy link
Member

Awesome, thanks! I'll add some downstream testing for the redhat.sso collection!

@guidograzioli guidograzioli changed the title Keycloak: add feature enabling/disabling Add profile features enabling/disabling May 31, 2023
@guidograzioli guidograzioli merged commit 24eaacc into ansible-middleware:main May 31, 2023
1 check passed
@hwo-wd hwo-wd deleted the feature/profiles branch June 1, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants