Improve service restart behavior configuration

[hwo-wd]

Add an extra parameter keycloak_service_restart_always which sets the systemd unit for keycloak to automaticcaly restart on the always condition. When keycloak_service_restart_always is True, keycloak_service_restart_on_failure must also be True.

Variable	Description	Default
keycloak_service_restart_always	systemd restart always behavior activation	False
keycloak_service_restart_on_failure	systemd restart on-failure behavior activation	False

[hwo-wd]

@guidograzioli, sry for the breaking change, but I guess it wasn't that widespread by now;
I didn't focus on downwards compatibility, let me know if you'd prefer a compatibility shim variable

[guidograzioli]

Hello, thanks for the PR. I believe allowing all the systemd values is too generic and does not directly apply to the keycloak startup script. In particular, I don't find an use case of always, on-success and on-watchdog, while failure, abnormal and abort would fall down to the same case. Do you have a specific case that would require this configurability?

[hwo-wd]

I agree with on-success, on-watchdog etc. being superfluous.
Hear me out though: my motivation was to introduce always as some administrators prefer to have this in production over on-failure and while I was at it, I decided to make it more generic than my previous try ;-).

I could remove all except for no, on-failure, and always, would that be ok for you?

[guidograzioli]

Ok, I see; how about this:

• keycloak_service_restart_always: new parameter, default False. Used to set the systemd restart value always
• keycloak_service_restart_on_failure remains as it is, default False, unless keycloak_service_restart_always is true, in which case by default is True. Sets the value as on-failure when true
  ?

And at the same time, the four parameters keycloak_service_* for tuning the restart behaviour, can you remove the jinja conditionals and just set to a static value? We can cope with having the variables defined even when the flags are False

[hwo-wd]

This should do the trick

[guidograzioli]

LGTM