Undefine keycloak_db_valid_conn_sql default
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rely on defaults set in keycloak_jdbc dict
|
Hello, thanks for the PR; what version of ansible are you on? We get the variable undefined, not empty string, in our CI testing. Anyway, I think the change makes sense, but I'd prefer the alternative Your thoughts? |
guidograzioli
added
the
bugfixes
guidograzioli
changed the title
keycloak_db_valid_conn_sql default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an empty string default for
keycloak_db_valid_conn_sqlresults in an empty value in the configuration file. We should rely on defaults set fokeycloak_jdbc.[database].validate_query.The alternative cloud be using
"{{ keycloak_db_valid_conn_sql | default('select 1', true) }}"value forkeycloak_jdbc.[database].validate_query