Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect checks for keycloak_jgroups_subnet #98

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix incorrect checks for keycloak_jgroups_subnet #98

merged 1 commit into from
Jun 23, 2023

Conversation

hwo-wd
Copy link
Collaborator

@hwo-wd hwo-wd commented Jun 23, 2023 •
edited by guidograzioli

An incorrect conditional in the jinja2 template caused the keycloak_jgroups_subnet to become required (otherwise wrong configuration would be generated).

Fix #97

guidograzioli
guidograzioli approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@guidograzioli guidograzioli merged commit f381540 into ansible-middleware:main Jun 23, 2023
1 check passed
@guidograzioli guidograzioli added the bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements label Jun 23, 2023
@guidograzioli guidograzioli changed the title Fix #97 - proper checks for keycloak_jgroups_subnet Fix incorrect checks for keycloak_jgroups_subnet Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#93 keycloak_jgroups_subnet introduced issue
2 participants
@hwo-wd @guidograzioli