Test network-engine against devel & stable, py2 & py3 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the roles are only "supported" on released versions of Ansible we should ensure there are no regressions in the devel branch. Some of the parsers require features that were first added in Ansible 2.5, so no point testing on older versions stable: py2 & py3 deve: py2
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
trishnaguha
approved these changes
May 14, 2018
rcarrillocruz
suggested changes
May 14, 2018
| @@ -2,7 +2,9 @@ | |||
| check: | |||
| jobs: | |||
| - tox-linters | |||
| - ansible-role-tests | |||
| - ansible-role-tests-stable-py2 | |||
There was a problem hiding this comment.
The job definitions for ansible/ansible should be in ansible/ansible.
The reason I put them on ansible-zuul-jobs was to a hack to work out a network integration zuul role.
What you need to do is :
- Install SF GH app on Ansible/ansible
- Create .zuul.yml with job definitions on ansible/ansible
- Put a depends-on on the ansible/ansible PR containing the .zuul.yml that depends on the roles on this ansible-zuul-jobs PR
There was a problem hiding this comment.
This PR is for testing network-engine, so I think this is the right place.
#13 will need moving to ansible/ansible
There was a problem hiding this comment.
ah sorry, got confused between the two links. This is good then
|
recheck |
|
Build succeeded.
|
gundalow
changed the title
rcarrillocruz
approved these changes
May 14, 2018
| @@ -2,7 +2,9 @@ | |||
| check: | |||
| jobs: | |||
| - tox-linters | |||
| - ansible-role-tests | |||
| - ansible-role-tests-stable-py2 | |||
There was a problem hiding this comment.
ah sorry, got confused between the two links. This is good then
|
recheck |
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This role adds pre-commit integration tests for
network-enginefor both Python 2 and Python 3 using the latest stable released version of Ansible.In addition we use Ansible devel with Python 2 to ensure there aren't any upstream changes that might cause us issues.
The
network-enginerole only supports Ansible 2.5.0 and newer, so no point testing on older Ansible releases.Although the roles are only "supported" on released versions of Ansible
we should ensure there are no regressions in the devel branch of Ansible.
stable: py2 & py3
deve: py2