Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unified requirements.yml for galaxy collections #1240

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

andreas-marschke
Copy link
Collaborator

This changeset provides support to find ansible-galaxy collection requirements.yml relative to repo path, in the collections/ directory. This supports inventory organisations where only one requirements.yml is set up for the entire repo.

This partially resolves issues reported here: #1144

This changeset provides support to find `ansible-galaxy` collection
`requirements.yml` relative to repo path, in the `collections/` directory.
This supports inventory organisations where only one requirements.yml is
set up for the entire repo.

This partially resolves issues reported here: semaphoreui#1144
@andreas-marschke
Copy link
Collaborator Author

@fiftin Anything stopping this from being code-reviewed/merged?

@fiftin
Copy link
Collaborator

fiftin commented Jul 22, 2023

Hi @andreas-marschke

I'm here :) I reviewing.

@rwaffen
Copy link

rwaffen commented Sep 13, 2023

is this still a thing?
i'm on v2.9.16 and still having the problem that $repository/collections/requirements.yml is ignored :(

@andreas-marschke
Copy link
Collaborator Author

@rwaffen As it hasn't been merged yet, I don't think it's resolved.

@rwaffen
Copy link

rwaffen commented Sep 13, 2023

it's a pitty. but how do you handle this as long this is not merged, is there a workaround for this?

@stefanux
Copy link

stefanux commented Sep 21, 2023

@rwaffen defining two requirement-files is the way to go and working (in 2.8.90, tested again with latest version 2.9.4):
roles/requirements.yml
collections/requirements.yml

minimal example for collections:

---
collections:
  - name: community.general

requirements are cached and only refreshed if file(s) are changed: "roles/requirements.yml has no changes. Skip galaxy install process.".
if you experience problems see output of semaphore and make another issue since this is a feature issue.

@RusticPotatoes
Copy link

any updates on getting this pr merged? @stefanux can help testing if needed

@steadfasterX
Copy link
Contributor

@fiftin any update on that one?

@corincorvus
Copy link

Any Updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants