Add WcaNoDefaultModelId exception #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamiTakamiya
force-pushed
the
ttakamiy/AAP-23031/improve-errmsg-when-org-has-apikey-but-no-model-id
branch
from
148ad52
to
b0419ba
Compare
goneri
reviewed
May 10, 2024
goneri
previously approved these changes
May 10, 2024
manstis
previously approved these changes
May 10, 2024
TamiTakamiya
force-pushed
the
ttakamiy/AAP-23031/improve-errmsg-when-org-has-apikey-but-no-model-id
branch
from
b0419ba
to
084c897
Compare
TamiTakamiya
changed the title
|
@robinbobbitt Would you take a look at this again? Thanks. |
goneri
approved these changes
May 23, 2024
TamiTakamiya
deleted the
ttakamiy/AAP-23031/improve-errmsg-when-org-has-apikey-but-no-model-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: AAP-23031
Description
This is the service side change corresponding to the vscode-ansible PR#1309. With this change, a new exception WcaOrganizationNotLinked is added for the case that the user is not linked to an organization because the WcaModelIdNotFound was thrown for those cases as well.
Testing
A test case is included in the PR.
Steps to test
Scenarios tested
See the above.
Production deployment
For the new WcaOrganizationNotLinkedException is correctly processed on VS Code extension, vscode-ansible PR#1309 needs to be merged.