Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize logger lines containing string formatting #385

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jun 2, 2022

Use of any formatting other than %-style formatting in logging messages should be avoided. If a logging message will not be logged, you waste cycles formatting the string that will just be thrown away. Using %-style lets the logging library decide when to format.

For reference:

@Shrews Shrews requested a review from a team as a code owner June 2, 2022 15:23
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Jun 2, 2022
@Shrews Shrews merged commit f92a3c9 into ansible:devel Jun 3, 2022
@Shrews Shrews deleted the logging-optim branch June 3, 2022 12:55
Shrews added a commit to Shrews/ansible-builder that referenced this pull request Jun 3, 2022
eqrx pushed a commit that referenced this pull request Jun 6, 2022
@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants