Add pulp_integration framework #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrews
force-pushed
the
new_gha
branch
15 times, most recently
from
a81d526
to
4ab8744
Compare
Shrews
changed the title
nitzmahone
reviewed
Jul 1, 2022
eqrx
suggested changes
Jul 3, 2022
|
Lastest working run against my fork: https://github.com/Shrews/ansible-builder/runs/7201566704?check_suite_focus=true |
eqrx
approved these changes
Jul 6, 2022
eqrx
reviewed
Jul 7, 2022
nitzmahone
reviewed
Jul 7, 2022
nitzmahone
approved these changes
Jul 11, 2022
|
Merging, should go green once it has access to local secrets. We may need to retarget the pulp job to only run on maintainer-sourced PRs or merge jobs only so it doesn't fail on all future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
pulp_integrationtest framework that will allow us to have a local image repository that supports signed images. The PR that adds support for container image signature validation (PR #371) will be able to use this to add integration tests.Note that the Pulp Integration job fails in this PR because it is adding a new GHA job that uses a secret. It will not have access to this secret until this is merged, but I verified that it does work as a PR against my own fork, seen here:
https://github.com/Shrews/ansible-builder/runs/7134536766?check_suite_focus=truehttps://github.com/Shrews/ansible-builder/runs/7201566704?check_suite_focus=truehttps://github.com/Shrews/ansible-builder/runs/7254569323?check_suite_focus=true