Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pulp setup #511

Merged
merged 2 commits into from
May 2, 2023
Merged

Fix for pulp setup #511

merged 2 commits into from
May 2, 2023

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented May 2, 2023

This fixes the pulp-integration job. Passing results at: https://github.com/Shrews/ansible-builder/actions/runs/4863096603/jobs/8670349109

  • Corrects the pulp setup script to run the specified pulp image (it was accidentally running with latest).
  • Bumps pulp image to 3.23.3.
  • Creates the registries.conf file in setup_pulp.sh now instead of within test_policies.py, while still trying to be considerate of local testing. This was accidentally working because we were running the test_policies.py tests before the test_v3.py tests. But since a previous change switched the order, the test_v3.py tests began failing because we couldn't connect to the pulp registry.
  • Remove the image prune and image delete that was happening in test_policies.py test setup. This was only a local testing convenience and doesn't need to happen in CI. As a result, removed the destructive marker.

@Shrews Shrews requested a review from a team as a code owner May 2, 2023 15:54
@Shrews Shrews merged commit b60f10c into ansible:devel May 2, 2023
11 checks passed
@Shrews Shrews deleted the pulp-fix branch May 2, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant