Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forced dnf upgrade, speed up tests #516

Merged
merged 5 commits into from
May 4, 2023
Merged

Remove forced dnf upgrade, speed up tests #516

merged 5 commits into from
May 4, 2023

Conversation

nitzmahone
Copy link
Member

supersedes #503 (included here)

  • removes the forced (and often very slow) dnf upgrade that occurred in several stages
  • speeds up integration tests by enabling build cache usage for most, and converting to lighter-weight EE v3 definitions
  • new optional build arg PKGMGR_PRESERVE_CACHE:
    • default none- clears package manager cache frequently
    • any value but always zaps the cache only at the end of install-from-bindep (good for CI, squashed images)
    • always never clears the package manager cache (good for CI, testing base images where a pre-populated package cache is handy)

@nitzmahone nitzmahone requested a review from a team as a code owner May 3, 2023 00:12
@github-actions github-actions bot added docs Changes to documentation needs_triage New item that needs to be triaged test Changes to test files labels May 3, 2023
Shrews
Shrews reviewed May 3, 2023
View reviewed changes
test/conftest.py Show resolved Hide resolved
test/data/prepend_steps/execution-environment.yml Outdated Show resolved Hide resolved
test/integration/test_build.py Outdated Show resolved Hide resolved
test/pulp_integration/test_policies.py Outdated Show resolved Hide resolved
test/integration/test_build.py Outdated Show resolved Hide resolved
Shrews and others added 3 commits May 3, 2023 17:14
@Shrews @nitzmahone
Change squash default from 'new' to 'off'
3917db2
@nitzmahone
remove forced OS package manager upgrade
bf347d8 
* enable build cache for most tests
* build arg to preserve pkgmgr cache
@nitzmahone
skip ARG directives only for None values
1738f3c 
* otherwise they can't be set/overridden at build-time
@nitzmahone nitzmahone force-pushed the test_build_cache_squash_off branch from f6fe465 to b0819bc Compare May 4, 2023 16:18
@nitzmahone nitzmahone force-pushed the test_build_cache_squash_off branch from b0819bc to daf3f3f Compare May 4, 2023 16:21
@nitzmahone nitzmahone mentioned this pull request May 4, 2023
Closed
@nitzmahone nitzmahone merged commit b7e922d into ansible:devel May 4, 2023
11 checks passed
@Shrews Shrews mentioned this pull request Jun 6, 2023
Closed
@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrews Shrews Shrews approved these changes

Assignees
No one assigned
Labels
docs Changes to documentation test Changes to test files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitzmahone @Shrews @Akasurde