Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set user value for the container image #521

Merged
merged 4 commits into from
May 4, 2023
Merged

Allow to set user value for the container image #521

merged 4 commits into from
May 4, 2023

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 4, 2023

  • Added options.user setting
  • Updated documentation with an example
  • Added unit tests

Fixes: #506

@Akasurde
Allow to set user value for the container image
e877560 
* Added options.user setting
* Updated documentation with an example
* Added unit tests

Fixes: ansible#506

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested a review from a team as a code owner May 4, 2023 17:45
@github-actions github-actions bot added docs Changes to documentation needs_triage New item that needs to be triaged labels May 4, 2023
@Akasurde
Updated indentation
d095003 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
nitzmahone
nitzmahone reviewed May 4, 2023
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good; might want to add a usage of options->user to the test/data/v3/complete EE def and one of the associated create integration tests to validate the right USER directive appearance in the final image stage.

@Akasurde
review comments
7bf77eb 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Fix integration tests
0f5c814 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@nitzmahone nitzmahone removed the needs_triage New item that needs to be triaged label May 4, 2023
@nitzmahone nitzmahone merged commit 77f54f0 into ansible:devel May 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd left review comments

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
docs Changes to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USER root vs USER 1000
3 participants
@Akasurde @shanemcd @nitzmahone