Fix collection loading #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the cache dir is added to the collection loader path, in order to allow linting a collection role against a module this collection is providing - Add missing default collection path to the loader for ansible version prior 2.15.0.dev0, as done by ansible's _configure_collection_loader(). The only remaining difference is the missing handling of COLLECTIONS_SCAN_SYS_PATH. See ansible/ansible-lint#2969 for reference. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
|
@apatard LGTM but can you please add a test? Just as safety measure to avoid regression. |
@ssbarnea I know I should have added two tests (1 for plugin in collection and 1 for the issue found in ansible-lint bug 2969) but I don't know enough the test suite to do that. If you can give me some clues about that, I can try adding them. |
|
@apatard I will take it over from here as there are few other changes needed. Funny, I reached the same bug while debugging something else. |
|
ok. Ping me if you need someone to test things. |
ssbarnea
approved these changes
Feb 14, 2023
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the cache dir is added to the collection loader path, in order to allow linting a collection role against a module this collection is providing
Add missing default collection path to the loader for ansible version prior 2.15.0.dev0, as done by ansible's _configure_collection_loader(). The only remaining difference is the missing handling of COLLECTIONS_SCAN_SYS_PATH.
See ansible/ansible-lint#2969 for reference.
Signed-off-by: Arnaud Patard apatard@hupstream.com