Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec file #291

Closed
wants to merge 2 commits into from
Closed

Add spec file #291

wants to merge 2 commits into from

Conversation

daaitudian
Copy link
Contributor

Hi,
I added a spec file to help rpm build.

@daaitudian daaitudian requested a review from a team as a code owner June 9, 2023 11:17
@ssbarnea ssbarnea added the bug Something isn't working label Jun 13, 2023
@ssbarnea
Copy link
Member

@daaitudian Can you please give me some hints regarding how to build locally using this spec.in file? On linter repo I only use a spec file and build using packit build locally.

@daaitudian
Copy link
Contributor Author

Hi @ssbarnea :

Here is a brief explanation,

  1. Fill in "Version", "Release" and "%Changelog" in the spec.in file according to the actual information

  2. Pack the source code into the style required by "Source0" then copy it to the Source folder. copy the rpm/python-ansible-compat.spec.in to the SPECS folder, and rename it to python-ansible-compat.spec

  3. Use the “rpmbuild” command to perform the rpm build

Reference document: https://www.redhat.com/sysadmin/create-rpm-package

Do I need to write a detailed README ?

@ssbarnea
Copy link
Member

@daaitudian Please take a look at #291 which we will merge soon. It is based on the setup we already have for ansible-lint and we use packit to test rpm building, which is basically essential for knowing that the spec is valid.

Still, I know that my PR does not update the changelog, so I will be more than happy if you could make one or two follow-ups to improve it.

The reason why I did not took you change was because I was not able to test it, especially on proposed PRs. There is no need to add documentation if we can ensure that the testing happens on CI -- I would call this self-documented ;)

@daaitudian
Copy link
Contributor Author

@ssbarnea Thanks a lot for your help and modification. I will follow up on it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants