This repository has been archived by the owner on Mar 23, 2019. It is now read-only.
Enable validate-config tests and add a new test #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request rebased (conflict fixed) |
Error message:
______ TestAnsibleContainerConfig.test_should_also_replace_pwd_in_volumes ______
self = <validate_config.TestAnsibleContainerConfig testMethod=test_should_also_replace_pwd_in_volumes>
def test_should_also_replace_pwd_in_volumes(self):
# test that ${PWD} gets resolved
self.config.cli_vars_files = self.vars_files
self.config.set_env('prod')
container.ENV = 'conductor'
container.utils.DataLoader = DataLoader
container.utils.VariableManager = VariableManager
container.utils.RoleInclude = RoleInclude
> conductor_config = AnsibleContainerConductorConfig(self.config._config)
ansible-container/test/tests/validate_config.py:145:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
ansible-container/container/__init__.py:19: in __wrapped__
return fn(*args, **kwargs)
ansible-container/container/config.py:357: in __init__
self._process_defaults()
ansible-container/container/config.py:390: in _process_defaults
callback=lambda processed: self._templar.set_available_variables(
ansible-container/container/config.py:375: in _process_section
yaml.round_trip_dump(value, buffer)
[...]
venv/3.6/lib/python3.6/site-packages/ruamel/yaml/emitter.py:422: in expect_flow_sequence
self.write_indicator(u' ' * ind + u'[', True, whitespace=True)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <ruamel.yaml.dumper.RoundTripDumper object at 0x7fbda6e59e48>
indicator = '[', need_whitespace = True, whitespace = True, indention = False
def write_indicator(self, indicator, need_whitespace,
whitespace=False, indention=False):
# type: (Any, Any, bool, bool) -> None
if self.whitespace or not need_whitespace:
data = indicator
else:
data = u' ' + indicator
self.whitespace = whitespace
self.indention = self.indention and indention
self.column += len(data)
self.open_ended = False
if bool(self.encoding):
data = data.encode(self.encoding)
> self.stream.write(data)
E TypeError: a bytes-like object is required, not 'str'
venv/3.6/lib/python3.6/site-packages/ruamel/yaml/emitter.py:1059: TypeError
|
@Voronenko could you review this one ? Extract from build log (17 passed in 1.91 seconds): |
|
@pilou- What issue no PR refers to, if any ? |
|
@Voronenko this pull-request:
|
|
@gregdek could you merge this one ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
validate-config tests:
Depends-On: #882