Integrate all-green #1632
Closed
Integrate all-green #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown standards fixup Co-authored-by: Don Naro <dnaro@redhat.com>
wording fixup Co-authored-by: Don Naro <dnaro@redhat.com>
Clearer description for why/when to tag Co-authored-by: Don Naro <dnaro@redhat.com>
language clarity fixup Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
silly typo fixup Co-authored-by: Don Naro <dnaro@redhat.com>
clarity fixup Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
typo Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Maxwell G <maxwell@gtmx.me>
Co-authored-by: Maxwell G <maxwell@gtmx.me>
Co-authored-by: Maxwell G <maxwell@gtmx.me>
|
This is related to issue #1284 |
oraNod
reviewed
Jun 24, 2024
| with: | ||
| allowed-failures: docs, linters | ||
| allowed-skips: non-voting-flaky-job | ||
| jobs: ${{ toJSON(needs) }} |
There was a problem hiding this comment.
@x1101 Just taking a cursory look through for now. I'll take another look tomorrow. Could you please add an extra line at the end of this file and the other one?
|
@x1101 Thanks for taking this on. It looks like you're working off the If I may make a suggestion, try creating a new feature branch with a descriptive name that tracks the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added All-green github action to
ci.yaml, requiring thenoxjob