Integrate the alls-green action into the main GHA CI workflow
#1639
Conversation
GitHub does not provide us with this context, so it's not possible to retrieve. |
webknjaz
changed the title
alls-green action into the main GHA CI workflow
When rebuilding this work after repo cleanup, I missed removing these. Thanks for catching that. Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Yeah, I was just highlighting the results of my testing and the limits of what this can provide, because the issue requesting doesn't really specify what information we were trying to get and I wanted it to be obvious what this does/doesn't do |
|
I'm honestly fine with the current approach. We already require the two docs build/checker jobs in the branch protection settings. |
But it requires somebody with proper access to continuously watch for the need to update the branch protection rules whenever workflows change, vs. having a transparent record of what's required. |
|
@oraNod can you add any appropriate backport labels (if we want this in anything other than devel for how)? |
oraNod
added
the
backport-2.17
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #1647 🤖 @patchback |
* Integrating all-greens into ci.yml * removing non-existing references When rebuilding this work after repo cleanup, I missed removing these. Thanks for catching that. Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> * Update .github/workflows/ci.yaml --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Don Naro <dnaro@redhat.com> (cherry picked from commit a732a1e)
|
@samccann Shoot. Guess I forgot the backport. Thanks for the reminder. Maybe we should just keep this on devel and stable-2.17. |
… (#1647) * Integrating all-greens into ci.yml * removing non-existing references When rebuilding this work after repo cleanup, I missed removing these. Thanks for catching that. Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> * Update .github/workflows/ci.yaml --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Don Naro <dnaro@redhat.com> (cherry picked from commit a732a1e) Co-authored-by: Lyle McKarns <x1101@users.noreply.github.com>
Resolves #1284.
Testing shows that this doesn't surfaces which part of the nox matrix fails, but does fail the workflow when any of them do.