Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new retries w/o until #310

Merged
merged 1 commit into from Aug 24, 2023
Merged

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Aug 21, 2023

@mkrizek mkrizek added the techreview needs technical review label Aug 21, 2023
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Aug 21, 2023
@@ -268,7 +268,7 @@ To see the results of individual retries, run the play with ``-vv``.

When you run a task with ``until`` and register the result as a variable, the registered variable will include a key called "attempts", which records the number of the retries for the task.

.. note:: You must set the ``until`` parameter if you want a task to retry. If ``until`` is not defined, the value for the ``retries`` parameter is forced to 1.
Copy link
Contributor Author

@mkrizek mkrizek Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure how docs versioning works now docs is in its own repo, should the note stay and the new information be guarded with version_added: 2.16?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the no-backport label should ensure this doesn't go anywhere but devel until 2.16 releases.

@felixfontein felixfontein added the no_backport THis PR should not be backported. devel only. label Aug 21, 2023
@oraNod oraNod removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2023
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mkrizek

@samccann samccann merged commit 3482179 into ansible:devel Aug 24, 2023
3 checks passed
@mkrizek mkrizek deleted the until-retries branch August 25, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_backport THis PR should not be backported. devel only. techreview needs technical review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants