Skip to content

Commit

Permalink
PR checks
Browse files Browse the repository at this point in the history
Issue: AAH-1845
  • Loading branch information
MilanPospisil committed Sep 23, 2022
1 parent 6df22d0 commit 9fe2a79
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,6 @@ class ExecutionEnvironmentList extends React.Component<
onSave={(promise, form) => {
promise
.then(() => {
debugger;
this.setState(
{
showRemoteModal: false,
Expand All @@ -468,18 +467,8 @@ class ExecutionEnvironmentList extends React.Component<
() => this.queryEnvironments(),
);
})
.catch((err) => {
debugger;
.catch(() => {
// do nothing, error already handled in modal

/*this.setState({
formError: err.response.data.errors.map((error) => {
return {
title: error.title,
detail: error.source.parameter + ': ' + error.detail,
};
}),
});*/
});
}}
onCancel={() =>
Expand Down
20 changes: 15 additions & 5 deletions src/utilities/map-error-messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,23 @@ export function isFieldValid(
errorMessagesType: ErrorMessagesType,
name: string,
) {
if (!errorMessagesType) return 'default';
if (errorMessagesType[name]) return 'error';
if (!errorMessagesType) {
return 'default';
}
if (errorMessagesType[name]) {
return 'error';
}

return 'default';
}

export function isFormValid(errorMessagesType: ErrorMessagesType) {
if (!errorMessagesType) return true;
if (Object.keys(errorMessagesType).length == 0) return true;
if (!errorMessagesType) {
return true;
}
if (Object.keys(errorMessagesType).length == 0) {
return true;
}

let valid = true;
// if any key contains error text inside, its invalid
Expand All @@ -54,7 +62,9 @@ export function isFormValid(errorMessagesType: ErrorMessagesType) {
// this function suppose that state contains formErrors variable, if not, it will not work
export function setError(state, setState, field, error) {
// if error is already present, dont set value again
if (state.formErrors[field] == error) return;
if (state.formErrors[field] == error) {
return;
}

state.formErrors[field] = error;
setState({ formErrors: state.formErrors });
Expand Down

0 comments on commit 9fe2a79

Please sign in to comment.