Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task detail page refreshes when that task not done #1001

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

ZitaNemeckova
Copy link
Member

Fixes https://issues.redhat.com/browse/AAH-954

Task detail page refreshes after 10s if the task is not done yet. No refresh when the task is done.

@ZitaNemeckova ZitaNemeckova added backported-4.4 This PR has been backported to stable-4.4 (2.1) backport-4.4 This PR should be backported to stable-4.4 (2.1) and removed backported-4.4 This PR has been backported to stable-4.4 (2.1) labels Sep 29, 2021
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍 :)

@ZitaNemeckova ZitaNemeckova merged commit 9c84ae8 into ansible:master Sep 30, 2021
@ZitaNemeckova ZitaNemeckova deleted the task_detail_refresh branch September 30, 2021 18:54
@patchback
Copy link

patchback bot commented Sep 30, 2021

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/9c84ae80814d82dee27ff339b5d6d5d69109c8c9/pr-1001

Backported as #1006

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 30, 2021
* Clean a bit

* Fixes https://issues.redhat.com/browse/AAH-954 - Task detail page reloads after 10s if task not done

* Fix refresh to be created/canceled at right time

* Remove one extra canceled

(cherry picked from commit 9c84ae8)
ZitaNemeckova added a commit that referenced this pull request Oct 4, 2021
* Clean a bit

* Fixes https://issues.redhat.com/browse/AAH-954 - Task detail page reloads after 10s if task not done

* Fix refresh to be created/canceled at right time

* Remove one extra canceled

(cherry picked from commit 9c84ae8)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants