Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EE detail: keep reloading every 10s and disable sync button when sync is in progress #1003

Merged
merged 1 commit into from
Oct 6, 2021
Merged

EE detail: keep reloading every 10s and disable sync button when sync is in progress #1003

merged 1 commit into from
Oct 6, 2021

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Sep 29, 2021

Fixes AAH-953

On the container detail page, when sync is in progress, disable the sync button, and keep refreshing the repo every 10s.

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Sep 30, 2021
@himdel
Copy link
Collaborator Author

himdel commented Oct 4, 2021 •
edited

Testing: #898 (comment)

(+ ansible/galaxy_ng#1006 should help with sync errors)

ZitaNemeckova
ZitaNemeckova approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@himdel himdel merged commit 06519b2 into ansible:master Oct 6, 2021
@himdel himdel deleted the ee-remote-detail-sync branch October 6, 2021 16:03
@patchback
Copy link

patchback bot commented Oct 6, 2021 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/06519b27c19635ba6223dcdc238f2567de62512d/pr-1003

Backported as #1046

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 6, 2021
@himdel
EE detail: keep reloading every 10s and disable sync button when sync…
d73ac23 
… is in progress (#1003)

(cherry picked from commit 06519b2)
@patchback patchback bot mentioned this pull request Oct 6, 2021
Merged
himdel added a commit that referenced this pull request Oct 6, 2021
@patchback @himdel
EE detail: keep reloading every 10s and disable sync button when sync…
9513208 
… is in progress (#1003) (#1046)

(cherry picked from commit 06519b2)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZitaNemeckova ZitaNemeckova ZitaNemeckova approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himdel @ZitaNemeckova