EE images: initial manifest list support #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
manifest-list
branch
2 times, most recently
from
9880ea8
to
22330f0
Compare
|
|
…sts, linking to Images
…rows and TODO pops up on the right line :)
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1049 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
* EE images: filter out layers already in a manifest list * EE images: isManifestList -> don't link to detail screen * EE manifest: handle API errors by showing a message about manifest lists, linking to Images * EE detail Images - add expand/collapse button on manifest list table rows and TODO pops up on the right line :) * EE detail Images: renderManifestList * EE Images - use exclude_child_manifests instead of UI filtering * OS/Arch -> OS / Arch (cherry picked from commit 9e771b0)
6 tasks
himdel
added a commit
that referenced
this pull request
Oct 7, 2021
* EE images: filter out layers already in a manifest list * EE images: isManifestList -> don't link to detail screen * EE manifest: handle API errors by showing a message about manifest lists, linking to Images * EE detail Images - add expand/collapse button on manifest list table rows and TODO pops up on the right line :) * EE detail Images: renderManifestList * EE Images - use exclude_child_manifests instead of UI filtering * OS/Arch -> OS / Arch (cherry picked from commit 9e771b0) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-965
API: ansible/galaxy_ng#997
This adds initial support for manifest list type images, which happen when pulling from remote registries.
The images list API returns all images, including manifest lists which just refer to the other images.
❕ this won't work if the manifest list is not returned in the same page as the images(fixed by usingexlcude_child_manifests)