Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumbs in EE detail page to make it consistent with nav #1037

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Fix breadcrumbs in EE detail page to make it consistent with nav #1037

merged 3 commits into from
Oct 7, 2021

Conversation

ZitaNemeckova
Copy link
Member

Before:
Screenshot 2021-10-05 at 12 18 35

After:
Screenshot 2021-10-05 at 12 16 54

@ZitaNemeckova ZitaNemeckova added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 5, 2021
@himdel
Copy link
Collaborator

himdel commented Oct 5, 2021 •
edited

Good catch 👍,
we also have this one:

src/containers/execution-environment-manifest/execution-environment-manifest.tsx
100:                  name: t`Container Registry`,

(there's also src/containers/execution-environment-list/execution_environment_list.tsx Container registry type, but that's referring to the actual EE remote registry, not a repo.)

himdel
himdel approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ZitaNemeckova ZitaNemeckova merged commit a5689d3 into ansible:master Oct 7, 2021
@ZitaNemeckova ZitaNemeckova deleted the fix_breadcrumbs branch October 7, 2021 06:46
@patchback
Copy link

patchback bot commented Oct 7, 2021 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/a5689d3e4d033051e7c6700db61360934a5ab3aa/pr-1037

Backported as #1048

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 7, 2021
@ZitaNemeckova
Fix breadcrumbs in EE detail page to make it consistent with nav (#1037)
0fcdc2e 
* Fix breadcrumbs in EE detail page to make it consistent with nav

* Fix breadcrumbs in Manifest page too

* Change e to E

(cherry picked from commit a5689d3)
@patchback patchback bot mentioned this pull request Oct 7, 2021
Merged
himdel pushed a commit that referenced this pull request Oct 7, 2021
@patchback @ZitaNemeckova
Fix breadcrumbs in EE detail page to make it consistent with nav (#1037…
38655b1 
…) (#1048)

* Fix breadcrumbs in EE detail page to make it consistent with nav

* Fix breadcrumbs in Manifest page too

* Change e to E

(cherry picked from commit a5689d3)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 7, 2021
ZitaNemeckova added a commit to ZitaNemeckova/ansible-hub-ui that referenced this pull request Oct 13, 2021
@ZitaNemeckova
Fix breadcrumbs in EE detail page to make it consistent with nav (ans…
94059a3 
…ible#1037)

* Fix breadcrumbs in EE detail page to make it consistent with nav

* Fix breadcrumbs in Manifest page too

* Change e to E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@jerabekjiri jerabekjiri Awaiting requested review from jerabekjiri

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZitaNemeckova @himdel