Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs in EE #1038

Merged
merged 1 commit into from Oct 6, 2021
Merged

Fix tabs in EE #1038

merged 1 commit into from Oct 6, 2021

Conversation

ZitaNemeckova
Copy link
Member

Fixes https://issues.redhat.com/browse/AAH-969

How to reproduce:

The page loads correctly first time and second time there's nothing

Before:

Screenshot 2021-10-05 at 12 19 51

After:

Screenshot 2021-10-05 at 12 21 52

@ZitaNemeckova ZitaNemeckova added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 5, 2021
@ZitaNemeckova ZitaNemeckova requested review from himdel and jerabekjiri and removed request for himdel October 5, 2021 10:22
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍 :)

(Eventually we should make it so clicking the tab again reloads it, but that can wait for page.)

@ZitaNemeckova ZitaNemeckova merged commit d8c48c8 into ansible:master Oct 6, 2021
@patchback
Copy link

patchback bot commented Oct 6, 2021

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/d8c48c89be3c9eb85d3bc73a48da3b66bde48907/pr-1038

Backported as #1043

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@ZitaNemeckova ZitaNemeckova deleted the fix_ee_tabs branch October 6, 2021 07:00
patchback bot pushed a commit that referenced this pull request Oct 6, 2021
(and remove unused import)

Fixes https://issues.redhat.com/browse/AAH-969

(cherry picked from commit d8c48c8)
himdel pushed a commit that referenced this pull request Oct 6, 2021
(and remove unused import)

Fixes https://issues.redhat.com/browse/AAH-969

(cherry picked from commit d8c48c8)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants