Add test for manual Collection upload #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
test_upload_collection
branch
from
7fd42fa
to
e99230f
Compare
himdel
reviewed
Nov 1, 2021
ZitaNemeckova
force-pushed
the
test_upload_collection
branch
2 times, most recently
from
a3d0389
to
49463f7
Compare
ZitaNemeckova
changed the title
ZitaNemeckova
force-pushed
the
test_upload_collection
branch
from
49463f7
to
0a8f2ea
Compare
himdel
reviewed
Nov 3, 2021
himdel
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
(Apart from the prettier issue above..)
LGTM 👍
We may want to consider adding a before that delete namespaces and collections .. but the test doesn't seem to need it, and collection deletion is being handled by other PRs, so I'm fine with postponing that until we're merging the collection tests into one :).
… less complicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/AAH-1011