Group edit: add more permissions #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. The only thing I would change is to reword "Remotes" to "Collection Remotes" and "Namepsaces" to "Collection Namespaces" |
newswangerd
approved these changes
Oct 25, 2021
These model_permissions can now get used by the UI, adding the appropriate constants ( https://github.com/ansible/galaxy_ng/pull/1003/files#diff-416aea42d5d99e187f7340543709cb3b126924b4fe30e6c36be869388c997845R141 ):  add_containerregistry  change_containerregistry  delete_collection  delete_containerregistry  delete_containerrepository  delete_namespace
…sions name for permissions used by the ui
himdel
force-pushed
the
group-permissions
branch
from
352adc1
to
6ebe689
Compare
|
Updated, thanks :) |
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1139 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
* merge HUMAN_GROUP_DETAIL_PERMISSIONS into PERMISSIONS[*].label * PERMISSIONS: add permissions used in 1002 These model_permissions can now get used by the UI, adding the appropriate constants ( https://github.com/ansible/galaxy_ng/pull/1003/files#diff-416aea42d5d99e187f7340543709cb3b126924b4fe30e6c36be869388c997845R141 ):  add_containerregistry  change_containerregistry  delete_collection  delete_containerregistry  delete_containerrepository  delete_namespace * PERMISSIONS: annotate each real permission name with the model_permissions name for permissions used by the ui * PERMISSIONS: add (commented out) unused permissions from CurrentUserSerializer * HUMAN_PERMISSIONS: sort * HUMAN_PERMISSIONS: add missing permissions * cypress: update allPerms for new permissions * adjust permission group names (cherry picked from commit 723f4cc)
6 tasks
himdel
added a commit
that referenced
this pull request
Oct 27, 2021
* merge HUMAN_GROUP_DETAIL_PERMISSIONS into PERMISSIONS[*].label * PERMISSIONS: add permissions used in 1002 These model_permissions can now get used by the UI, adding the appropriate constants ( https://github.com/ansible/galaxy_ng/pull/1003/files#diff-416aea42d5d99e187f7340543709cb3b126924b4fe30e6c36be869388c997845R141 ):  add_containerregistry  change_containerregistry  delete_collection  delete_containerregistry  delete_containerrepository  delete_namespace * PERMISSIONS: annotate each real permission name with the model_permissions name for permissions used by the ui * PERMISSIONS: add (commented out) unused permissions from CurrentUserSerializer * HUMAN_PERMISSIONS: sort * HUMAN_PERMISSIONS: add missing permissions * cypress: update allPerms for new permissions * adjust permission group names (cherry picked from commit 723f4cc) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-1024
Follow-up to #1002, after ansible/galaxy_ng#1003 .. add the newly added permissions to the UI.
I've added all permissions mentioned in the backend PR to
HUMAN_PERMISSIONSand toPERMISSIONS, together with a comment showing their name inuser.model_permissions, parenthesised if unused... except we don't have all the permissions in
PERMISSIONS, only those that get used, so commenting the new unused ones out.Newly exposed permissions (these are the same that get used as of #1002)
ansible.delete_collectioncontainer.delete_containerrepositorygalaxy.add_containerregistryremotegalaxy.change_containerregistryremotegalaxy.delete_containerregistryremotegalaxy.delete_namespaceNew permissions not made visible (gleamed from ansible/galaxy_ng#1003):
ansible.add_ansibledistributionansible.delete_ansibledistributionansible.add_collectionremoteansible.delete_collectionremotecontainer.add_containerdistributioncontainer.change_containerdistributioncontainer.delete_containerdistributioncontainer.add_containerrepositorycontainer.change_containerrepositorycontainer.delete_containernamespace(we have human names for all of these, so all we need is to uncomment them if needed)
With the added permissions, I was able to: