Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong displaying of username in delete user from group #1086

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix wrong displaying of username in delete user from group #1086

merged 1 commit into from
Oct 18, 2021

Conversation

jerabekjiri
Copy link
Contributor

No Issue

Quick fix of displaying of the username in DeleteModal in GroupDetail user list.

Before:
Screenshot from 2021-10-15 14-31-29

After:
Screenshot from 2021-10-15 14-31-55

ZitaNemeckova
ZitaNemeckova approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 LGTM 👍

@jerabekjiri jerabekjiri merged commit 700d058 into ansible:master Oct 18, 2021
@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 30, 2021
@patchback
Copy link

patchback bot commented Oct 30, 2021 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/700d0583325543a0fa8edbd9f7be3afa3e09b613/pr-1086

Backported as #1148

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 30, 2021
@jerabekjiri
fix username in group remove modal (#1086)
ccc2e81 
(cherry picked from commit 700d058)
@patchback patchback bot mentioned this pull request Oct 30, 2021
Merged
himdel pushed a commit that referenced this pull request Oct 30, 2021
@patchback @jerabekjiri
fix username in group remove modal (#1086) (#1148)
b1528eb 
(cherry picked from commit 700d058)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZitaNemeckova ZitaNemeckova ZitaNemeckova approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerabekjiri @ZitaNemeckova @himdel