Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EE delete modal: don't hide name while still waiting for task #1151

Merged
merged 1 commit into from
Nov 1, 2021
Merged

EE delete modal: don't hide name while still waiting for task #1151

merged 1 commit into from
Nov 1, 2021

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 30, 2021

the modal shows the name of the EE to remove, but only until we reset selectedItem (where we're taking the name from), which was happening before waitForTask is done, making the name disappear mid-delete.

Unset selectedItem only when closing the modal instead.

@himdel
EE delete modal: don't hide name while still waiting for task
fde0738 
the modal shows the name of the EE to remove, but only until we reset selectedItem, which was happening before waitForTask is done
ZitaNemeckova
ZitaNemeckova approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Nov 1, 2021
@himdel himdel merged commit 91ee08d into ansible:master Nov 1, 2021
@himdel himdel deleted the ee-delete-modal branch November 1, 2021 14:24
@patchback
Copy link

patchback bot commented Nov 1, 2021 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/91ee08d248aadd7f7d8f179788e769e3eb1a7478/pr-1151

Backported as #1185

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 1, 2021
@himdel
EE delete modal: don't hide name while still waiting for task (#1151)
7ffbfb0 
the modal shows the name of the EE to remove, but only until we reset selectedItem, which was happening before waitForTask is done

(cherry picked from commit 91ee08d)
@patchback patchback bot mentioned this pull request Nov 1, 2021
Merged
@himdel
Copy link
Collaborator Author

himdel commented Dec 7, 2021

Fixes https://issues.redhat.com/browse/AAH-1182

himdel added a commit that referenced this pull request Dec 7, 2021
@patchback @himdel
EE delete modal: don't hide name while still waiting for task (#1151) (…
553b8f5 
…#1185)

the modal shows the name of the EE to remove, but only until we reset selectedItem, which was happening before waitForTask is done

(cherry picked from commit 91ee08d)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZitaNemeckova ZitaNemeckova ZitaNemeckova approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himdel @ZitaNemeckova